fix: fix hcs calibration bug #482
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
- Coverage 87.81% 87.79% -0.02%
==========================================
Files 106 106
Lines 11676 11701 +25
==========================================
+ Hits 10253 10273 +20
- Misses 1423 1428 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| self._min_wells_required = min(3, plate.rows * plate.columns) | ||
| else: | ||
| self._min_wells_required = 3 |
There was a problem hiding this comment.
I think a flexible min_wells_required sort of misses the point. Specifically: this determines whether we can calibrate for rotation (this value is used below in _origin_spacing_rotation). You always need 3 points for rotation, so a 2x1 doesn't just require 2 min_wells ... it still requires 3. This variable is ultimately more about "can/should we calibrate for rotation or not". It's always 3, or not possible
There was a problem hiding this comment.
🤦♂️ you're right sorry...I'll find a better fix😀!
2 participants
Fixes the bug in #481 where, when using the HCSWizard with a plate type that has only 1 row and 1 column (or any plate with fewer than 3 wells, e.g. coverslip-18-mm-square), the user cannot proceed to the FOV selection page after calibration because the UI enforces “calibrate at least 3 wells”.
closes #481 .